[webkit-reviews] review denied: [Bug 11015] SVG handles em units incorrectly : [Attachment 10794] First attempt

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Sep 27 01:09:11 PDT 2006

Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 11015: SVG handles em units incorrectly

Attachment 10794: First attempt

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Looks great!

You'll need to add a test case to make sure that dynamic updates are still
working properly after your changes.

Also, now that I think about it more, calcViewport should not take an argument,
but rather should use element().

You probably don't need to call calcViewport unless selfNeedsLayout() is true.

Fix those, then I'll r+ it.

More information about the webkit-reviews mailing list