[webkit-reviews] review requested: [Bug 4980] CSS2: Counters not supported : [Attachment 10788] Patch the addresses Darin's comments, but leaks

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Sep 26 17:21:17 PDT 2006


Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 4980: CSS2: Counters not supported
http://bugzilla.opendarwin.org/show_bug.cgi?id=4980

Attachment 10788: Patch the addresses Darin's comments, but leaks
http://bugzilla.opendarwin.org/attachment.cgi?id=10788&action=edit

------- Additional Comments from Beth Dakin <bdakin at apple.com>
So here is a patch that, I believe, addressess all of Darin's comments.
However, I am leaking CounterNodes all over the place. I think that I need to
do something to make the HashMap clean them up correctly. Since there is so
much other stuff in this patch too, I thought I'd post it anyway while I am
working on that.



More information about the webkit-reviews mailing list