[webkit-reviews] review denied: [Bug 9887] REGRESSION: WebContinuousSpellCheckingEnabled should enable continuous spell checking on all text areas : [Attachment 10520] Proposed Patch

[bugzilla-request-daemon at opendarwin.org]

Timothy Hatcher <timothy at hatcher.name> has denied Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 9887: REGRESSION: WebContinuousSpellCheckingEnabled should enable
continuous spell checking on all text areas
http://bugzilla.opendarwin.org/show_bug.cgi?id=9887

Attachment 10520: Proposed Patch
http://bugzilla.opendarwin.org/attachment.cgi?id=10520&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
isContinuousSpellCheckingEnabled is semi hot code, so it would be best to just
have a file static BOOL continuousSpellCheckingEnabled. This will be faster
than a lookup through NSUserDefaults.

Also we usually don't store these toggled settings in a NSUserDefault, the
application would normally do this and call setContinuousSpellCheckingEnabled
with the default value. We don't have a default
for setSmartInsertDeleteEnabled, etc. If we did add a new NSUserDefaults key,
it should be added to WebPreferenceKeysPrivate.h.