[webkit-reviews] review denied: [Bug 10338] When contentEditable, cursor doesn't change to hand : [Attachment 10722] patch 3

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Sep 25 21:50:19 PDT 2006

Timothy Hatcher <timothy at hatcher.name> has denied Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 10338: When contentEditable, cursor doesn't change to hand

Attachment 10722: patch 3

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
I think AlwaysLive would be the best default, since this will match Tiger's

This is the first WebPreference we have added like this... I think they should
be enums in WebKit also. Using a string is OK, but the enum makes more sense I
think. If we did use strings we would need to add constansts for all the values
that can be used in an app, like the key.

Also you will need to make your change to WebPreferencesPrivate.h, since this
is new API we will need to stage it there first until it can be approved inside
Apple for API.

The WebCore part seems fine. You will need to make the WebCore and WebKit enums
match, then you can just cast them back and forth in the bridge.

More information about the webkit-reviews mailing list