[webkit-reviews] review requested: [Bug 10920] IWebFrameLoadDelegate methods are not being called properly : [Attachment 10743] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Sep 24 15:12:24 PDT 2006

MorganL <morganl.webkit at yahoo.com> has asked  for review:
Bug 10920: IWebFrameLoadDelegate methods are not being called properly

Attachment 10743: patch

------- Additional Comments from MorganL <morganl.webkit at yahoo.com>
This patch hooks up a few more of the IWebFrameLoadDelegate methods, and it
also revises Spinneret to update the URL bar better.

I'm think that Frame::begin() is begin called too early.  I think it should be
called once we have HTTP response headers for the resulting load, but when I
moved it down to receivedResponse, stuff didn't work right.  So, I did not
include that change in this patch.

More information about the webkit-reviews mailing list