[webkit-reviews] review denied: [Bug 11009] Auto-generate the internal methods interfaces for the Objective-C bindings : [Attachment 10740] patch 2

[bugzilla-request-daemon at opendarwin.org]

Timothy Hatcher <timothy at hatcher.name> has denied Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 11009: Auto-generate the internal methods interfaces for the Objective-C
bindings
http://bugzilla.opendarwin.org/show_bug.cgi?id=11009

Attachment 10740: patch 2
http://bugzilla.opendarwin.org/attachment.cgi?id=10740&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
This looks good except one change:

-    removeWrapperForRGB(reinterpret_cast<uintptr_t>(_internal));  
+    removeWrapperForRGB(reinterpret_cast<WebCore::RGBA32>(_internal));

I made this change originally to uintptr_t so building for 64-bit would work.
You will get a warning about truncating a 64-bit point to a 32-bit value if you
use WebCore::RGBA32.

r=me if you revert the changes in DOMRGBColor.mm.