[webkit-reviews] review requested: [Bug 10338] When contentEditable, cursor doesn't change to hand (Need WebPreference?) : [Attachment 10722] patch 3

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Sep 23 09:20:25 PDT 2006


Graham Dennis <Graham.Dennis at gmail.com> has asked  for review:
Bug 10338: When contentEditable, cursor doesn't change to hand (Need
WebPreference?)
http://bugzilla.opendarwin.org/show_bug.cgi?id=10338

Attachment 10722: patch 3
http://bugzilla.opendarwin.org/attachment.cgi?id=10722&action=edit

------- Additional Comments from Graham Dennis <Graham.Dennis at gmail.com>
Newer and even more improved patch! This patch includes a quad-state
WebPreference for editable link behaviour called WebKitEditableLinkBehaviour.
The four states are:
* AlwaysLive (Safari 2 behaviour)
* OnlyLiveWithShiftKey (Previous WebKit-ToT behaviour)
* LiveWhenNotFocused (Dan's behaviour, links are live only when the editable
block containing them isn't focused)
* DefaultBehaviour (This is the same as OnlyLiveWithShiftKey)

I'm not certain that I've done the WebPreference correctly, but I've included
ChangeLog entries anyway.

No automatic testcase is included as I don't see how it is possible, however I
have modified the manual testcase for bug 7156.



More information about the webkit-reviews mailing list