[webkit-reviews] review granted: [Bug 4872] XMLHttpRequest fails to throw an exception when there is a security violation (mismatching domains) : [Attachment 10501] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Sep 23 00:54:24 PDT 2006


Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 4872: XMLHttpRequest fails to throw an exception when there is a security
violation (mismatching domains)
http://bugzilla.opendarwin.org/show_bug.cgi?id=4872

Attachment 10501: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=10501&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
I've read through this a couple times over the last week or so.  I also just
talked with ap about it again over irc.

The code looks sane.  Most important here are the tests.  So long as we have
excellent XHR testing coverage, I'm happy.

It's sad that this string has to be repeated so many times:
return throwError(exec, SyntaxError, "Not enough arguments");

You've noted these try/catches are for testing in IE:
+	 try {
+	     req.overrideMimeType('text/xml');
+	 } catch (ex) {
+	 }
IMO it's best to log any exceptions, even if they're specific to a single
browser.

This should have a bug about it:
-    // FIXME: Should this abort instead if we already have a m_job going?
+    // FIXME: Should this abort or raise an exception instead if we already
have a m_job going?


looks good.  r=me.



More information about the webkit-reviews mailing list