[webkit-reviews] review requested: [Bug 4980] CSS2: Counters not supported : [Attachment 10717] Preliminary counter implementation

[bugzilla-request-daemon at opendarwin.org]

Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 4980: CSS2: Counters not supported
http://bugzilla.opendarwin.org/show_bug.cgi?id=4980

Attachment 10717: Preliminary counter implementation
http://bugzilla.opendarwin.org/attachment.cgi?id=10717&action=edit

------- Additional Comments from Beth Dakin <bdakin at apple.com>
Here is a patch to implement counters. It is based largely on the KHTML
implementation. A few things about this patch:

1. There are definitely still bugs with counters. There are a bunch of great
counters test cases at http://dbaron.org/css2.1/tests/imported-20050702/ I plan
to check in a bunch of them as layout tests, and file bugs on all of the ones
that don't yet work.

2. List items should be re-written to be rendered with counters. KHTML does
this, and I have a patch that would make them switch over. I do not want to
switch them over yet, though, because of the bugs that still exist in this
counters patch (see above!). I will file an additional bug for this switch. It
doesn't seem worth it to do the switch now and introduce regressions into lists
when we can just switch it later when counters are more robust.

3. I don't think the test case attached to this bug is valid. Unless I am
mis-reading the spec, of course. Anyway, as I mentioned before, there are lots
of great tests at http://dbaron.org/css2.1/tests/imported-20050702/