[webkit-reviews] review granted: [Bug 10837] REGRESSION: Yahoo New Charts Crashes WebKit. : [Attachment 10678] Proposed patch without the tabs

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Sep 21 02:31:06 PDT 2006


Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10837

Attachment 10678: Proposed patch without the tabs
http://bugzilla.opendarwin.org/attachment.cgi?id=10678&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Looks good to me.  Too bad this logic can't be put in the DOM c++
implementation class.  That would sure make later auto-generation of
JSHTMLDocument easier.

Curious.  I wonder if this is broken in the Obj-C version of this wrapper?

Otherwise it looks fine.  r=me.



More information about the webkit-reviews mailing list