[webkit-reviews] review granted: [Bug 10953] Test results for fast/js/window-properties.html should include children of window.document.body.firstChild : [Attachment 10670] New results and improvement to test

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Sep 20 11:34:28 PDT 2006


Timothy Hatcher <timothy at hatcher.name> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 10953: Test results for fast/js/window-properties.html should include
children of window.document.body.firstChild
http://bugzilla.opendarwin.org/show_bug.cgi?id=10953

Attachment 10670: New results and improvement to test
http://bugzilla.opendarwin.org/attachment.cgi?id=10670&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
+    if (type == 'object' && propertyValue == null)
+        type = 'null';

This can be simplified with type === null. You made this change locally. r=me



More information about the webkit-reviews mailing list