[webkit-reviews] review requested: [Bug 10950] Need way for embedders to provide link coloring on Windows : [Attachment 10672] Patch to add WebKitInstance and WebHistoryDelegate

[bugzilla-request-daemon at opendarwin.org]

Marvin Decker <marv.decker at gmail.com> has asked  for review:
Bug 10950: Need way for embedders to provide link coloring on Windows
http://bugzilla.opendarwin.org/show_bug.cgi?id=10950

Attachment 10672: Patch to add WebKitInstance and WebHistoryDelegate
http://bugzilla.opendarwin.org/attachment.cgi?id=10672&action=edit

------- Additional Comments from Marvin Decker <marv.decker at gmail.com>
This patch adds a singleton COM object IWebKitInstance that embedders can
access. It seems like there will be a variety of global controls that embedders
will need access to, and this interface would be used to manage those things.

It adds an interface IWebHistoryDelegate and a setter for this on the
WebKitInstance. The embedder would implement IWebHistoryDelegate which would
then get called for coloring links.

In this patch, WebCore::historyContains is implemented in the WebKitInstance
file. From my understanding of the direction WebKit is going, the difference
between WebKit and WebCore is being moved or decreased. Link coloring is also
performance critical, so I wanted to decrease the number of abstraction layers
that it has to go through (I think this one COM layer is still more than I
would prefer).