[webkit-reviews] review requested: [Bug 10917] REGRESSION (r16027): iFrame transparency broken : [Attachment 10655] Patch fixes this

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Sep 19 16:58:16 PDT 2006


Timothy Hatcher <timothy at hatcher.name> has asked  for review:
Bug 10917: REGRESSION (r16027): iFrame transparency broken
http://bugzilla.opendarwin.org/show_bug.cgi?id=10917

Attachment 10655: Patch fixes this
http://bugzilla.opendarwin.org/attachment.cgi?id=10655&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
- Don't paint the background color if we are told to do slow repaints.
- Removed unneeded Color isValid() checks where we also check alpha() > 0.
- Removed a check for alpha() > 0 before calling fillRect() since it also
checks.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBackgroundExtended):



More information about the webkit-reviews mailing list