[webkit-reviews] review requested: [Bug 10908] Don't crash in Gdk's ~FontPlatformData : [Attachment 10639] updated patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Sep 19 00:47:56 PDT 2006

Krzysztof Kowalczyk <kkowalczyk at gmail.com> has asked  for review:
Bug 10908: Don't crash in Gdk's ~FontPlatformData

Attachment 10639: updated patch

------- Additional Comments from Krzysztof Kowalczyk <kkowalczyk at gmail.com>
1. Honestly, I didn't see any tabs in my previous patch. This one shouldn't
have them either.

2. Setting to -1 isn't nice but apparently someone thought it's a good idea.
Mac's version does the same:

    : font((NSFont*)-1), syntheticBold(false), syntheticOblique(false)

I don't understand this trick with Deleted, I'm just trying to prevent a crash
if this path is taken.

3. Also updated FrameGdk to add latest additions.

More information about the webkit-reviews mailing list