[webkit-reviews] review denied: [Bug 9976] Fix negative width issue in Hixie's test : [Attachment 10555] Another attempt

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Sep 18 21:15:51 PDT 2006

Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 9976: Fix negative width issue in Hixie's test

Attachment 10555: Another attempt

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
I'm not sure why I didn't r- this before.  The unsafe cast would prevent this
from landing.

However, I think it's also time to finally fix the SVGLength issue, and maybe
that part of this patch should be broken off into a separate patch.  To fix
SVGLength would require all uses of x()->doSomethingToTheLength() to be
removed.  and setX(new SVGLength()) to be used instead.  Better yet would be to
stop using Length* and instead store the values on the objects themselves.

Let's talk over IRC, maybe we can find a smaller piece to chop off for this

More information about the webkit-reviews mailing list