[webkit-reviews] review requested: [Bug 10927] ResourceLoaderClient::receivedRedirect is never called : [Attachment 10636] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Sep 18 19:22:32 PDT 2006

MorganL <morganl.webkit at yahoo.com> has asked  for review:
Bug 10927: ResourceLoaderClient::receivedRedirect is never called

Attachment 10636: patch

------- Additional Comments from MorganL <morganl.webkit at yahoo.com>
This patch makes it so that client()->receivedRedirect is called.

I also took a stab at cleaning up the large WndProc in ResourceLoaderWin.cpp. 
I found a way to avoid the heap-allocated struct passed to PostMessage, and I
also got rid of the unnecessary call to RegisterWindowMessage, replacing it
with WM_USER + N.  I hope you will consider these changes as I believe they
make ResourceLoaderWin.cpp much more manageable.

The code for INTERNET_STATUS_USER_INPUT_REQUIRED is needed in case WinInet is
configured to prompt on security warnings, etc.

More information about the webkit-reviews mailing list