[webkit-reviews] review denied: [Bug 10907] REGRESSION: New Icon Loaders don't handle certain non-server-root URLs correctly : [Attachment 10622] Small changes go a long way

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Sep 18 09:49:06 PDT 2006


John Sullivan <sullivan at apple.com> has denied John Sullivan
<sullivan at apple.com>'s request for review:
Bug 10907: REGRESSION: New Icon Loaders don't handle certain non-server-root
URLs correctly
http://bugzilla.opendarwin.org/show_bug.cgi?id=10907

Attachment 10622: Small changes go a long way
http://bugzilla.opendarwin.org/attachment.cgi?id=10622&action=edit

------- Additional Comments from John Sullivan <sullivan at apple.com>
typo in comment: "it's url(s)" should be "its"

+    // FIXME - Need to be able to do the following platform independently
+#if PLATFORM(MAC)
+    FrameMac* frameMac = Mac(this);
+    iconDatabase->setIconURLForPageURL(icon.url(),
frameMac->originalRequestURL().url());
+#endif
+}

I think the right way to do this is to override this method in FrameMac and
call through to super before handling the frameMac->originalRequestURL case.
Then other platforms can do the same thing if they are also keeping track of
the original request URL some other way.

Please either make this change or explain why it isn't the right approach. The
rest of the patch looks fine.



More information about the webkit-reviews mailing list