[webkit-reviews] review denied: [Bug 10908] Don't crash in Gdk's ~FontPlatformData : [Attachment 10613] don't crash in Gdk's FontPlatformData; allow closing gdklauncher via windows' close button

[bugzilla-request-daemon at opendarwin.org]

Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 10908: Don't crash in Gdk's ~FontPlatformData
http://bugzilla.opendarwin.org/show_bug.cgi?id=10908

Attachment 10613: don't crash in Gdk's FontPlatformData; allow closing
gdklauncher via windows' close button
http://bugzilla.opendarwin.org/attachment.cgi?id=10613&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
This has tabs.

This looks very scary:
+    if (m_pattern && ((FcPattern*)-1 != m_pattern))

is m_pattern being initialized to -1 ??

Other than that it looks fine.

WebKitTools/GdkLauncher/main.cpp will likely need your copyright added.