[webkit-reviews] review denied: [Bug 10903] Yet Another Objective-C Bindings Patch : [Attachment 10608] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Sep 17 14:45:28 PDT 2006

Timothy Hatcher <timothy at hatcher.name> has denied Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 10903: Yet Another Objective-C Bindings Patch

Attachment 10608: patch

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
+#import <WebCore/DOMDOMImplementation.h>

THis was in the original order because once in WebKit is will be:

#import <WebCore/DOMImplementation.h>

So the order in WeCore is wrong but it will be right once in WebKit.

DOMObject.h needs to include DOMException.h since you removed the enum from

isContentEditable should be for ObjC only. This naming schee is only common in
ObjC (with the "is" prefix for boolean types.) Other languages should just be
"bool contentEditible". I am fine keeping isContentEditable as a hand
implemented method.

More information about the webkit-reviews mailing list