[webkit-reviews] review requested: [Bug 10903] Yet Another
Objective-C Bindings Patch : [Attachment 10608] patch
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sun Sep 17 14:12:09 PDT 2006
Sam Weinig <sam.weinig at gmail.com> has asked for review:
Bug 10903: Yet Another Objective-C Bindings Patch
http://bugzilla.opendarwin.org/show_bug.cgi?id=10903
Attachment 10608: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=10608&action=edit
------- Additional Comments from Sam Weinig <sam.weinig at gmail.com>
- Whitespace cleanup for IDLParser.pm
- Add conditional #ifdefs (ie. #ifdef SVG_SUPPORT) to auto-generated
implementation files.
- Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException
and DOMAbstractView into their own files.
- Remove private method [DOMRGBColor _color] from DOMPrivate.h asit is not used
and a public method is available now.
- Remove internal method [DOMDocument _ownerElement] from DOMInternal.h as it
not used.
- Auto-generate method isContentEditable for DOMNode.
- General cleanup of bindings code including removing unneeded #imports and
whitespace cleanup.
More information about the webkit-reviews
mailing list