[webkit-reviews] review requested: [Bug 10896] REGRESSION: WebKit can't be built with SVG disabled : [Attachment 10603] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Sep 17 06:57:30 PDT 2006

Graham Dennis <Graham.Dennis at gmail.com> has asked  for review:
Bug 10896: REGRESSION: WebKit can't be built with SVG disabled

Attachment 10603: patch

------- Additional Comments from Graham Dennis <Graham.Dennis at gmail.com>
The problem is not that DerivedSources/WebCore/DOMXPathExpression.mm shouldn't
exist, but that it should have a #ifdef XPATH_SUPPORT at the start of the file.
This is a general problem for the ObjC generated code that have the Conditional
extended attribute set. This patch modifies CodeGeneratorObjC.pm to add #ifdef
/ #endif pairs to the appropriate files.

More information about the webkit-reviews mailing list