[webkit-reviews] review requested: [Bug 10842] REGRESSION (r15418): contenteditable div truncates rightmost Japanese character : [Attachment 10598] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Sep 17 02:04:36 PDT 2006


Graham Dennis <Graham.Dennis at gmail.com> has asked  for review:
Bug 10842: REGRESSION (r15418): contenteditable div truncates rightmost
Japanese character
http://bugzilla.opendarwin.org/show_bug.cgi?id=10842

Attachment 10598: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=10598&action=edit

------- Additional Comments from Graham Dennis <Graham.Dennis at gmail.com>
Patch using Mitz's suggesstion.

I also did a logic shuffle at Mitz's request to prevent re-testing the same
expression twice in quick succession in two if statements (currentCharacterIsWS
&& o->style()->breakOnlyAfterWhiteSpace() && !midWordBreak)



More information about the webkit-reviews mailing list