[webkit-reviews] review requested: [Bug 3240] Support the frame and rules attributes on HTML tables : [Attachment 10593] Address some of Eric's concerns

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Sep 16 16:41:57 PDT 2006


Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 3240: Support the frame and rules attributes on HTML tables
http://bugzilla.opendarwin.org/show_bug.cgi?id=3240

Attachment 10593: Address some of Eric's concerns
http://bugzilla.opendarwin.org/attachment.cgi?id=10593&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Ok, I cleaned up the static casts and compacted that code.

I did not convert the member variables to RefPtrs.  I started to do so and
realized that the code surrounding the caching of these variables is (right
now) completely buggy (only the body member is actually being ref'ed right
now).  Because the problem is more complicated (and not relevant at all to this
patch),  I'm filing a followup bug about making the management of those
pointers better (both RefPtr conversion and then making them update properly as
well).



More information about the webkit-reviews mailing list