[webkit-reviews] review denied: [Bug 6002] WebKit does not properly handle SVG <cursor> element : [Attachment 10574] Another attempt

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Sep 15 15:10:58 PDT 2006

Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 6002: WebKit does not properly handle SVG <cursor> element

Attachment 10574: Another attempt

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
I'm still not a big fan of needing a separate class "CursorList" to hold all
the nodes, when the individual CursorData nodes could just form a singly linked
list and know how to delete their "next" pointer when they are themselves

This would also remove the need for RenderStyle::addCursor...

+using namespace SVGNames;

needs to be inside a SVG_SUPPORT block in FrameView.cpp

Is there any need to check the type here?
+	     value = valueList->next(); // comma

We'll need some more tests.

It's not clear to me how the CursorList is ever destroyed.

It's also not clear to me that two divs, one inside the other, both which use
independent cursor fallback will properly function (i.e. when is the cursors()
list cleared?)

I don't think we can land this without at least answering the leak question.

More information about the webkit-reviews mailing list