[webkit-reviews] review granted: [Bug 10835] REGRESSION: LOTS of SVG-related leaks : [Attachment 10578] Updated patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Sep 15 14:40:55 PDT 2006


Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 10835: REGRESSION: LOTS of SVG-related leaks
http://bugzilla.opendarwin.org/show_bug.cgi?id=10835

Attachment 10578: Updated patch
http://bugzilla.opendarwin.org/attachment.cgi?id=10578&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
This could be done cleaner, without having to modify the generator, or having
getFirst() etc, return a RefPtr (instead of a raw pointer).

Given how many leaks the existing code causes, I think it's worth landing this
now, and filling a follow-up bug about cleanup.



More information about the webkit-reviews mailing list