[webkit-reviews] review granted: [Bug 10813] REGRESSION (r16245): double-clicking on javascript exceptions fails to show source : [Attachment 10543] A hack-ish fix.

[bugzilla-request-daemon at opendarwin.org]

Alexey Proskuryakov <ap at nypop.com> has granted Alexey Proskuryakov
<ap at nypop.com>'s request for review:
Bug 10813: REGRESSION (r16245): double-clicking on javascript exceptions fails
to show source
http://bugzilla.opendarwin.org/show_bug.cgi?id=10813

Attachment 10543: A hack-ish fix.
http://bugzilla.opendarwin.org/attachment.cgi?id=10543&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
r=me (yes, even without a ChangeLog entry ;) )

I think that this patch properly fixes the regression, but the behavior is
still seriously broken. This code path is used when HTTP headers don't specify
an encoding, but there are numerous other ways for WebCore to pick one, and the
same encoding should be used for handling a resource and for providing it
source, obviously. 

+    NSString* name = textEncodingName ? textEncodingName : @"Latin-1";

We usually call this encoding "iso-8859-1". Might make sense to do so here for
consistency, as well.