[webkit-reviews] review requested: [Bug 10338] When contentEditable, cursor doesn't change to hand (Need WebPreference?) : [Attachment 10556] patch 2

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Sep 14 07:02:32 PDT 2006


Graham Dennis <Graham.Dennis at gmail.com> has asked  for review:
Bug 10338: When contentEditable, cursor doesn't change to hand (Need
WebPreference?)
http://bugzilla.opendarwin.org/show_bug.cgi?id=10338

Attachment 10556: patch 2
http://bugzilla.opendarwin.org/attachment.cgi?id=10556&action=edit

------- Additional Comments from Graham Dennis <Graham.Dennis at gmail.com>
New and improved patch. This patch fixes the patch rot, adds comments, cleans
up the selectCursor function and checks for frames that are 0. This patch also
includes a ChangeLog and modifies the comments in the testcase for bug #7156 (a
manual test) to mention the changes in behaviour made by this patch.

This patch does not use WebPreferences, but I can add that if it is decided
that that is desired.



More information about the webkit-reviews mailing list