[webkit-reviews] review denied: [Bug 10845] Various bugs in
ResourceLoaderWin with local files : [Attachment 10546] patch
2.1 - using svn-create-patch
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Wed Sep 13 16:24:17 PDT 2006
Brady Eidson <beidson at apple.com> has denied Brady Eidson <beidson at apple.com>'s
request for review:
Bug 10845: Various bugs in ResourceLoaderWin with local files
http://bugzilla.opendarwin.org/show_bug.cgi?id=10845
Attachment 10546: patch 2.1 - using svn-create-patch
http://bugzilla.opendarwin.org/attachment.cgi?id=10546&action=edit
------- Additional Comments from Brady Eidson <beidson at apple.com>
void ResourceLoader::fileLoadTimer(Timer<ResourceLoader>* timer)
{
+ client()->receivedResponse(this, 0);
This seems to me to introduce incorrect behavior - client->receivedResponse()
is only supposed to be called when the HTTP response comes back for a HTTP
request. If it's only data you're talking about, client->receivedData() is all
that needs to be called.
Can you tell use what the crash is you're seeing?
More information about the webkit-reviews
mailing list