[webkit-reviews] review granted: [Bug 10836] REGRESSION: Mac implementation of Font::drawGlyphs leaks a CGColorRef : [Attachment 10548] Patch

[bugzilla-request-daemon at opendarwin.org]

Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 10836: REGRESSION: Mac implementation of Font::drawGlyphs leaks a
CGColorRef
http://bugzilla.opendarwin.org/show_bug.cgi?id=10836

Attachment 10548: Patch
http://bugzilla.opendarwin.org/attachment.cgi?id=10548&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
My mistake, thanks for fixing.

You might add a:
 // WebCore expects text to respect the pen color, CG expects text to use fill

comment to the other place as well, I had meant to do that originally.

Also, this makes me wonder if it wouldn't be a better idea to set the color on
the context with 4 floats to prevent the malloc/free associated with creating a
color and freeing...  If it shows up in shark we'll have to move to that model.


r=me