[webkit-reviews] review requested: [Bug 3244] Support the 'label' element in HTML forms : [Attachment 10521] Patch that fully implements label

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Sep 12 22:35:41 PDT 2006


Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 3244: Support the 'label' element in HTML forms
http://bugzilla.opendarwin.org/show_bug.cgi?id=3244

Attachment 10521: Patch that fully implements label
http://bugzilla.opendarwin.org/attachment.cgi?id=10521&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I came up with a way to do this that still uses defaultEventHandler but that
manages to hack the hover/active state for the controls properly.  It's a bit
like Martin's approach but a little more generic (it doesn't try to special
case any particular control type).  My RenderLayer suggestion was lame (it
worked but is not nearly as elegant as this new way of doing hover/active,
which ensures that hover/active sitll works on the label too).



More information about the webkit-reviews mailing list