[webkit-reviews] review granted: [Bug 10792] Remove the
[Exclude=LANGUAGE] idiom from IDL's and code generators for
something better : [Attachment 10500] patch
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Mon Sep 11 09:12:56 PDT 2006
Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 10792: Remove the [Exclude=LANGUAGE] idiom from IDL's and code generators
for something better
http://bugzilla.opendarwin.org/show_bug.cgi?id=10792
Attachment 10500: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=10500&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
I think we should consider symbols more like LANGUAGE_JAVASCRIPT and
LANGUAGE_OBJECTIVE_C instead of JS and OBJC, to avoid accidental substitution,
say if someone had a variable named "JS".
I personally like #ifndef X better than #if !defined(X).
r=me
More information about the webkit-reviews
mailing list