[webkit-reviews] review denied: [Bug 10323] REGRESSION: javascript: URL containing '\\' gets passed as '//' : [Attachment 10478] Patch - Revised

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Sep 10 12:40:56 PDT 2006

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 10323: REGRESSION: javascript: URL containing '\\' gets passed as '//'

Attachment 10478: Patch - Revised

------- Additional Comments from Darin Adler <darin at apple.com>
The code change is good, but I think this comment change is a bad idea:

-    // for compatibility with Win IE, we must treat backslashes as if they
were slashes
+    // temporary fix for proper backslash substitution

You've replaced a comment that mentions the Win IE compatibility issue with one
that is considerably more vague. The comment says this is "temporary" without
explaining what's temporary about it or when the temporary time would be over.
The comment says "proper backslash substitution" but there's no explanation for
why backslashes need to be substituted at all or what would be proper vs.

Patch is great otherwise, but review- for the comment.

More information about the webkit-reviews mailing list