[webkit-reviews] review requested: [Bug 10801] REGRESSION: Styled form controls lose their intrinsic margins : [Attachment 10482] Rework intrinsic margin code

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Sep 9 23:44:22 PDT 2006

Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 10801: REGRESSION: Styled form controls lose their intrinsic margins

Attachment 10482: Rework intrinsic margin code

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This patch reworks intrinsic margins and consolidates all the code in one

Before this code was found in three places: old form controls, the themes for
engine controls, and the layer for ensuring resizers didn't cause jumpiness.

Now the intrinsic margin is adjusted in one place: adjustRenderStyle.  It's
done regardless of how the control is implemented (old, new, styled, unstyled,

This means that some controls are no going to acquire intrinsic margins that
didn't before (I believe this is a good thing, since now all controls will be
consistent).  The biggest change will be the image button.

More information about the webkit-reviews mailing list