[webkit-reviews] review granted: [Bug 10795] Auto-generate the
Objective-C DOM XPath bindings : [Attachment 10480] patch
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sat Sep 9 19:22:00 PDT 2006
Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 10795: Auto-generate the Objective-C DOM XPath bindings
http://bugzilla.opendarwin.org/show_bug.cgi?id=10795
Attachment 10480: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=10480&action=edit
------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Looks fine. r=me.
+//- (DOMXPathResult *)evaluate:(DOMNode *)contextNode type:(unsigned
short)type inResult:(DOMXPathResult *)inResult;
+- (DOMXPathResult *)evaluate:(DOMNode *)contextNode :(unsigned short)type
:(DOMXPathResult *)inResult;
There should be a comment added about how we can remove the old style binding
once internal clients are moved off of it. The XPath bindings have never been
public.
Otherwise looks fine. r=me.
More information about the webkit-reviews
mailing list