[webkit-reviews] review granted: [Bug 10791] Even More Objective-C DOM auto-generation cleanup : [Attachment 10479] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Sep 9 14:16:04 PDT 2006

Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 10791: Even More Objective-C DOM auto-generation cleanup

Attachment 10479: patch

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
My thoughts

1.  not a fan of exclude=JS, it seems to be used for Obj-C only bindings.  This
only hinders efforts to make other language bindings (like ruby, python, perl,

2.  I don't think the xpath stuff should be included in this patch.

3.  xpath stuff shouldn't need OldStyleObjC, since it's never shipped.

Other than that the patch looks fine.  r=me  (assuming you remove the xpath

More information about the webkit-reviews mailing list