[webkit-reviews] review requested: [Bug 6002] WebKit does not properly handle SVG <cursor> element : [Attachment 10468] Improved patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Sep 8 14:54:45 PDT 2006


Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 6002: WebKit does not properly handle SVG <cursor> element
http://bugzilla.opendarwin.org/show_bug.cgi?id=6002

Attachment 10468: Improved patch
http://bugzilla.opendarwin.org/attachment.cgi?id=10468&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
This is my "old" patch, but compiling against ToT and addressing most of
Darin's (style) issues.
It also includes aps test from comment 12. The patch seems to behave well, but
maybe could pick
up some things from Erics patch and more testing against aps testcases.
Nevertheless, I think it
may be worthwhile to review once again, and see what should be fixed, and how
much of cursor
support we need to land.
Cheers,

Rob.



More information about the webkit-reviews mailing list