[webkit-reviews] review granted: [Bug 10547] REGRESSION: Links that should open in a new window open in the same window, while opening another blank window : [Attachment 10428] patch with change log

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Sep 8 09:55:34 PDT 2006


Brady Eidson <beidson at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 10547: REGRESSION: Links that should open in a new window open in the same
window, while opening another blank window
http://bugzilla.opendarwin.org/show_bug.cgi?id=10547

Attachment 10428: patch with change log
http://bugzilla.opendarwin.org/attachment.cgi?id=10428&action=edit

------- Additional Comments from Brady Eidson <beidson at apple.com>
I discussed with Darin in IRC that perhaps the "[self release]; return;" could
be managed different because it's used multiple times as the "bail out" code...
 We agreed there should be an "exit method:" label and use gotos instead. 
Otherwise, r+



More information about the webkit-reviews mailing list