[webkit-reviews] review denied: [Bug 10765] Windows build busted due to std::copy usage in Vector.h : [Attachment 10444] alternatve patch: no pragmas

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Sep 8 09:41:01 PDT 2006

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 10765: Windows build busted due to std::copy usage in Vector.h

Attachment 10444: alternatve patch: no pragmas

------- Additional Comments from Darin Adler <darin at apple.com>
I really like this approach.

But since std::copy is really just a while loop, there's no reason to change
the semantics and possibly the performance characteristics just to get rid of

We could just create a couple local variables and write the loop by hand to
avoid the warning. Or write our own equivalent of the std::function.

I suggest we consider changing to the uninitializedCopy approach on its own
merits rather than doing it as part of this change.

I'm going to mark this review- because of that issue, even though I really like
the direction of this fix.

More information about the webkit-reviews mailing list