[webkit-reviews] review requested: [Bug 10765] Windows build busted due to std::copy usage in Vector.h : [Attachment 10444] alternatve patch: no pragmas

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Sep 7 15:36:37 PDT 2006


MorganL <morlmor at yahoo.com> has asked  for review:
Bug 10765: Windows build busted due to std::copy usage in Vector.h
http://bugzilla.opendarwin.org/show_bug.cgi?id=10765

Attachment 10444: alternatve patch: no pragmas
http://bugzilla.opendarwin.org/attachment.cgi?id=10444&action=edit

------- Additional Comments from MorganL <morlmor at yahoo.com>
This patch solves the problem a different way.	It just avoids std::copy
altogether.  Note: for basic types that support memcpy, this is probably better
since it replaces a for-loop + memcpy with a single memcpy.  For more complex
types, it means an extra pass over the array, which might hurt locality of
reference, so perhaps that's reason to poo-poo this patch :-/



More information about the webkit-reviews mailing list