[webkit-reviews] review denied: [Bug 10743] windows build is busted
: [Attachment 10430] followup patch
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Thu Sep 7 08:36:18 PDT 2006
Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 10743: windows build is busted
http://bugzilla.opendarwin.org/show_bug.cgi?id=10743
Attachment 10430: followup patch
http://bugzilla.opendarwin.org/attachment.cgi?id=10430&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
The ascii -> latin1 changes are good, although there are probably more
efficient ways to do things in those functions.
The TextEncodingRegistry.cpp is not needed. We added an unconditional include
of <ctype.h> last night, so there's no need for one with PLATFORM(WIN) in it.
More information about the webkit-reviews
mailing list