[webkit-reviews] review granted: [Bug 10728] text encodings should
work without a numeric ID : [Attachment 10400] new patch,
improved and addresses Alexey's comments
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Tue Sep 5 09:50:16 PDT 2006
Alexey Proskuryakov <ap at nypop.com> has granted Alexey Proskuryakov
<ap at nypop.com>'s request for review:
Bug 10728: text encodings should work without a numeric ID
http://bugzilla.opendarwin.org/show_bug.cgi?id=10728
Attachment 10400: new patch, improved and addresses Alexey's comments
http://bugzilla.opendarwin.org/attachment.cgi?id=10400&action=edit
------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
r=me
+ , m_decoder(new Decoder("text/css" , charset))
This line has now got a space before comma.
+ if (!length)
+ return String();
Oops, I overlooked that TextCodecUTF16::decode() ignores its flush parameter.
Could it perhaps be more consistent to output U+FFFD if there's an odd byte?
Though it's hard to imagine any practical use for one (spotting errors?)
More information about the webkit-reviews
mailing list