[webkit-reviews] review requested: [Bug 10714] ObjC autogeneration needs safe-guards against easily modifying the public API : [Attachment 10397] Fixes this along with some other tweaks

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Sep 4 17:33:48 PDT 2006


Timothy Hatcher <timothy at hatcher.name> has asked  for review:
Bug 10714: ObjC autogeneration needs safe-guards against easily modifying the
public API
http://bugzilla.opendarwin.org/show_bug.cgi?id=10714

Attachment 10397: Fixes this along with some other tweaks
http://bugzilla.opendarwin.org/attachment.cgi?id=10397&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
- New PublicDOMInterfaces.h file is consulted when generating
  the ObjC DOM files. All public DOM class interfaces, properties
  and methods need to be in this file. Anything not in the file will
  be generated into the appropriate private header file. During
  generation if something changed or is missing in the public API
  a build error will occur. New interfaces added to the IDLs files
  will now not automatically be reflected in the public ObjC API.
  Methods commented out in PublicDOMInterfaces.h are pending public
  and will be uncommented once approved.

- Removed most of the Exclude=ObjC uses from the IDL files. This
  attribute was mostly used to prevent changes to the public headers.

- Make a new parameter name if the original conflicts with a property name.

- Simplified the generation code for dealing with exceptions.

- Moved file opens to WriteData. Files are unlinked before
  being opened to work around a Leopard file truncation bug.

- Fixed #imports for DOMImplementation to be DOMDOMImplementation.h



More information about the webkit-reviews mailing list