[webkit-reviews] review granted: [Bug 10696] RenderPathQuartz and RenderPathQt should not be needed : [Attachment 10381] Even more improved patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Sep 3 13:27:15 PDT 2006


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 10696: RenderPathQuartz and RenderPathQt should not be needed
http://bugzilla.opendarwin.org/show_bug.cgi?id=10696

Attachment 10381: Even more improved patch
http://bugzilla.opendarwin.org/attachment.cgi?id=10381&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+typedef enum {
+    Start,
+    Mid,
+    End
+} MarkerType;

Should be just enum.

+    typedef void (*PathApplierFunction) ( void* info, const PathElement*
element);

Extra space after parenthesis. No need to include the word element.

r=me



More information about the webkit-reviews mailing list