[webkit-reviews] review granted: [Bug 10676] @charset rules not accessible via DOM : [Attachment 10350] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Sep 3 12:13:22 PDT 2006

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 10676: @charset rules not accessible via DOM

Attachment 10350: proposed patch

------- Additional Comments from Darin Adler <darin at apple.com>
Do we really need those empty blocks in the yacc source? It looks cleaner to me
with no block at all when there's no code.

I'm really not a fan of boolean parameters like omitCharsetRules, but I don't
have anything better to suggest. It should be omitCharsetRules with an "s" by
the way.


More information about the webkit-reviews mailing list