[webkit-reviews] review granted: [Bug 10697] REGRESSION (r16175): Errors in incremental decoding of UTF-8 : [Attachment 10376] proposed fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Sep 3 09:43:03 PDT 2006

Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 10697: REGRESSION (r16175): Errors in incremental decoding of UTF-8

Attachment 10376: proposed fix

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
ap and I talked about this over IRC.

This looks sane.

I complained to ap about the duplicated logic for encoding fallback which seems
to exist in both setEncodingName and the constructor here.  It would be nice to
get rid of that (fewer code repetitions leads to cleaner and less fragile

ap noted that there would be an upcoming re-write of TextEncoding to get rid of
custom-encoding to ID tables.

All and all this looks sane.  I just have to trust you that our test cases are
adequate to cover this.

More information about the webkit-reviews mailing list