[webkit-reviews] review requested: [Bug 10685] ObjC DOM should have
no unnamed parameters : [Attachment 10358] Implements this
and other small tweaks
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Fri Sep 1 21:25:51 PDT 2006
Timothy Hatcher <timothy at hatcher.name> has asked for review:
Bug 10685: ObjC DOM should have no unnamed parameters
http://bugzilla.opendarwin.org/show_bug.cgi?id=10685
Attachment 10358: Implements this and other small tweaks
http://bugzilla.opendarwin.org/attachment.cgi?id=10358&action=edit
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
- The ObjC code generation script now outputs parameter prefixes
for methods that have more than 1 parameter. This prefix is simply
the parameter name. Some parameter names have been changed in the IDL
files to produce good prefixes. Please don't change existing
parameter names, or the ObjC API will change.
- A backwards compatible version of the method is placed in a
category with a deprecation marco for 10.5 and later. This step only
happens if the IDL extended attribute "OldStyleObjC" is defined.
All new functions in IDL should not get this attribute.
- Moved RemoveExcludedAttributesAndFunctions to CodeGenerator.pm
so it can be shared between the two generators.
- The ObjC generate will now die before starting if the platform is
not Mac OS. This is determined by the "OS" env variable Xcode sets.
- Many cleanup tweaks in CodeGeneratorObjC.pm.
- Removed IDL and CSS files from the project's resource copy phase,
these do no need to be in WebCore's resources.
* WebCore.xcodeproj/project.pbxproj
* bindings/scripts/CodeGenerator.pm
* bindings/scripts/CodeGeneratorJS.pm
* bindings/scripts/CodeGeneratorObjC.pm
* css/CSSPrimitiveValue.idl
* dom/CharacterData.idl
* dom/DOMImplementation.idl
* dom/Document.idl
* dom/Element.idl
* dom/KeyboardEvent.idl
* dom/MouseEvent.idl
* dom/MutationEvent.idl
* dom/NamedNodeMap.idl
* dom/UIEvent.idl
* html/HTMLCanvasElement.idl
* html/HTMLSelectElement.idl
* ksvg2/bindings/idl/svg/SVGLengthList.idl
* ksvg2/bindings/idl/svg/SVGNumberList.idl
* ksvg2/bindings/idl/svg/SVGPointList.idl
* ksvg2/bindings/idl/svg/SVGStringList.idl
* ksvg2/bindings/idl/svg/SVGTextContentElement.idl
* ksvg2/bindings/idl/svg/SVGTransformList.idl
* ksvg2/svg/SVGSVGElement.idl
* page/DOMWindow.idl
More information about the webkit-reviews
mailing list