[webkit-reviews] review denied: [Bug 11321] Element with :target
pseudo-class still matched after fragment identifier change :
[Attachment 11192] first attempt
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Tue Oct 31 04:31:35 PST 2006
Maciej Stachowiak <mjs at apple.com> has denied Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 11321: Element with :target pseudo-class still matched after fragment
identifier change
http://bugs.webkit.org/show_bug.cgi?id=11321
Attachment 11192: first attempt
http://bugs.webkit.org/attachment.cgi?id=11192&action=edit
------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
The fix looks ok to me, however, it needs a test case. To make a test case for
this, you will probably have to make a page that navigates to a #fragment via
window.location, forces a layout to make the :target pseudo match (for example
by asking for a clientHeight property), then navigates to no fragment at all.
Please resubmit with test case. The code change looks fine however.
More information about the webkit-reviews
mailing list