[webkit-reviews] review denied: [Bug 11433] Fixes to get WebKit to run on windows : [Attachment 11242] Implementation of AffineTransform for Cairo

[bugzilla-request-daemon at macosforge.org]

Maciej Stachowiak <mjs at apple.com> has denied Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 11433: Fixes to get WebKit to run on windows
http://bugs.webkit.org/show_bug.cgi?id=11433

Attachment 11242: Implementation of AffineTransform for Cairo
http://bugs.webkit.org/attachment.cgi?id=11242&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Thanks for hte patch!

Mostly this looks good. However, the implementation of mapRect is not correct.
Mapping a rect is not equivalent to mapping a point and a distance. Consider
the case of a rotated rect. In that case, you need to get the final bounding
box accounting for rotation. This is what the CG and Qt implementatios will do.


Also, the patch should include a ChangeLog entry.

Please address these issues and resubmit.