[webkit-reviews] review requested: [Bug 11461] HitTestResult should be split into HitTestRequest and HitTestResult : [Attachment 11289] Creates a struct for the request

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Mon Oct 30 13:10:34 PST 2006


Beth Dakin <bdakin at apple.com> has asked Darin Adler <darin at apple.com> for
review:
Bug 11461: HitTestResult should be split into HitTestRequest and HitTestResult
http://bugs.webkit.org/show_bug.cgi?id=11461

Attachment 11289: Creates a struct for the request
http://bugs.webkit.org/attachment.cgi?id=11289&action=edit

------- Additional Comments from Beth Dakin <bdakin at apple.com>
The thing that I dislike about this patch is that it adds a new boolean
parameter to all of the nodeAtPoint()s. The only nodeAtPoint() implementation
to use any of the fields of HitTestRequst is RenderFrameSet::nodeAtPoint()
which asks about readonly. So instead of sending the entire HitTestRequest into
all of the nodeAtPoint()s, I just sent the readonly value. I wish I didn't have
to do that since no one else needs it, but it doesn't seem like there is
another way. Or is there??



More information about the webkit-reviews mailing list