[webkit-reviews] review granted: [Bug 11441] More rendering code cleaning : [Attachment 11279] updated patch

[bugzilla-request-daemon at macosforge.org]

mitz at webkit.org has granted mitz at webkit.org's request for review:
Bug 11441: More rendering code cleaning
http://bugs.webkit.org/show_bug.cgi?id=11441

Attachment 11279: updated patch
http://bugs.webkit.org/attachment.cgi?id=11279&action=edit

------- Additional Comments from mitz at webkit.org
Great work! I have 3 comments which you should fix when landing.

"its", not "it's":

+// FIXME: move this to it's own file

"IntRect &exposeRect" -> "IntRect& exposeRect":

+    IntRect getRectToExpose(const IntRect& visibleRect,  const IntRect
&exposeRect, const ScrollAlignment& alignX, const ScrollAlignment& alignY);    


'b' is a bad name, but 'firstLine' is better than no name:

-    virtual short lineHeight(bool b, bool isRootLineBox=false) const;
-    virtual short baselinePosition(bool b, bool isRootLineBox=false) const;
+    virtual short lineHeight(bool, bool isRootLineBox = false) const;
+    virtual short baselinePosition(bool, bool isRootLineBox = false) const;